Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option to skip an error when downloading images from ls #361

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

baslia
Copy link
Collaborator

@baslia baslia commented Nov 18, 2024

What

When downloading labelled images from LS to locally to train an Ultratics model, if there is a connection issue, it will stop downloading the images entirely.

While I don't mind missing a couple of images, that would be great to have an option to skip those errors. Or at least to increase the number of retry.

I implemented the option to skip the download on error

@baslia baslia added the ✨ enhancement New feature or request label Nov 18, 2024
@baslia baslia requested a review from a team as a code owner November 18, 2024 06:45
@baslia
Copy link
Collaborator Author

baslia commented Nov 18, 2024

For some reason, my previous PR was included as well ...

@@ -245,7 +251,10 @@ def add_prediction(
threshold = 0.1

model = YOLO(model_name)
model.set_classes(labels)
if hasattr(model, "set_classes"):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was from my previous PR, but it is running and error when I have a locally pre-trained model, hence this handling method

Copy link
Contributor

@raphael0202 raphael0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raphael0202 raphael0202 merged commit 0a127ad into develop Nov 18, 2024
5 of 6 checks passed
@raphael0202 raphael0202 deleted the skip-error-option-for-datasets-cli branch November 18, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants