refactor(ContributionAssistant): More UX tweaks following feedback #1039
Conversation
| return { | ||
| productFormFilled: false, | ||
| pricePriceFormFilled: false, | ||
| categoryPricePerList: [ |
There was a problem hiding this comment.
note to self: refactor this somehow (used in 3 files)
| @@ -16,12 +24,20 @@ | |||
| /> | |||
| <v-card-text> | |||
| <ProductInputRow :productForm="productPriceForm" :disableInitWhenSwitchingModes="true" @filled="productFormFilled = $event" /> | |||
| <v-alert | |||
There was a problem hiding this comment.
last bit missing, is to set the mode as barcode if a product_code is detected ?? or is there many false-positives ?
There was a problem hiding this comment.
Sorry, didn't understand this comment.
But maybe this context helps: gemini always tries its best to set a value to all fields. So its reply almost always contains a barcode, even when no barcodes were in the image (it likes to put the price in the barcode field for these cases)
Related fun fact: I've noticed it also does something similar with origin countries that are not in its enum set, replacing it with countries that are close geographically or culturally. For example, if its set includes CHINA and BRAZIL, and the read origin is CHILE, it tends to reply with BRAZIL, instead of the closer word CHINA, which is surprising (and pretty cool).
There was a problem hiding this comment.
its to avoid the click to select "barcode" instead of "category" (category is selected by default ?).
and users are lost or don't necessarily know that the barcode is hidden behind that mode
There was a problem hiding this comment.
So the suggestion is to have "barcode" selected by default instead of "category" ?
I wonder if users would also get lost for crops without barcodes, with gemini putting a random number as barcode, and users not knowing that the category is hidden behind the other mode.
There was a problem hiding this comment.
I need to take a closer look at the gemini response, if the barcode field is always returned.
Or maybe couple gemini with a classifier ? That would tell us if the image is a barcode or a category ??
There was a problem hiding this comment.
There's probably a way of modifying the prompt, asking specifically for EAN13 barcodes or empty strings. It might even lead to better parsing results !
|
I ended up following the advice of moving the proof upload process as the first step. This is more in-lines with other processes of Open Prices (reuses the ProofInputRow components) It breaks the idea of handling multiple proofs for the same location, but feedback seems to show that this is not how the tool is used. Moreover, with the multiple-proof upload page in construction, I guess the process will be to use this feature to add many proofs for a store at once, then use the contribution assistant on the existing proofs. Using recent proofs skips the compression and proof upload process, which slows down the assistant quite a lot. Finally, I also fully disabled the possibility of going back when we reach the summary step (after price upload). The only way to add a new proof is to press the corresponding button that refreshes the page.
|
What
Screenshots
Part of