Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more Wikidata properties #127

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

teolemon
Copy link
Member

What

  • feat: add more Wikidata properties

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that it's a good idea to add those properties as methods. I think it would be better to have a dict that map long property name to description and use it (if needed) in the template or where needed.

@@ -19,10 +19,312 @@ def image_prop(self):
def OSM_prop(self):
return self._client.get("P402")

@cached_property
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your indentation is wrong…
@cached_property is for class methods.

@alexgarel
Copy link
Member

@teolemon make lint

Copy link
Member

@sumit-158 sumit-158 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, We have to populate these properties to other places like in "off.py"...

@teolemon teolemon added 📚 Documentation Improvements or additions to documentation 🐳 Docker 🧪 Tests and removed docker documentation tests labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants