-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more Wikidata properties #127
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that it's a good idea to add those properties as methods. I think it would be better to have a dict that map long property name to description and use it (if needed) in the template or where needed.
app/wikidata_utils.py
Outdated
@@ -19,10 +19,312 @@ def image_prop(self): | |||
def OSM_prop(self): | |||
return self._client.get("P402") | |||
|
|||
@cached_property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your indentation is wrong…
@cached_property is for class methods.
@teolemon make lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, We have to populate these properties to other places like in "off.py"...
What