Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding responsive dashboard #38

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

sumit-158
Copy link
Member

What

  • Currently it have responsive dashboard , local navigations are yet to push

Screenshot

image

Fixes bug(s)

@sumit-158 sumit-158 requested a review from g123k July 2, 2022 08:51
Copy link
Contributor

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Far better @sumit-158. Just minor feedback!

client/lib/themes/theme_constants.dart Outdated Show resolved Hide resolved
import 'package:responsive_builder/responsive_builder.dart';

final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey();
AppBar topNavigationBar(BuildContext context, GlobalKey<ScaffoldState> key) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is-this a method? It should be a class!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u mean appbar inside class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error
image

client/lib/widgets/top_nav.dart Outdated Show resolved Hide resolved
client/lib/themes/theme_constants.dart Outdated Show resolved Hide resolved
@sumit-158
Copy link
Member Author

Also @g123k can you please help me with the local navigation, I don't understand how to do it.

@g123k
Copy link
Contributor

g123k commented Jul 2, 2022

Also @g123k can you please help me with the local navigation, I don't understand how to do it.

No pb. From which screen to which screen to you want to navigate to?

@sumit-158
Copy link
Member Author

sumit-158 commented Jul 2, 2022

No pb. From which screen to which screen to you want to navigate to?

Currently the landing page is active group , but I want when someone clicks on joined ,create group it opens new screen for each

@g123k
Copy link
Contributor

g123k commented Jul 3, 2022

No pb. From which screen to which screen to you want to navigate to?

Currently the landing page is active group , but I want when someone clicks on joined ,create group it opens new screen for each

You have two options:

  • Use unnamed routes
Navigator.push(
    context,
    MaterialPageRoute(builder: (context) => YourSecondPage()),
  );
  • Use named routes
  1. Setup routes (explained here)
  2. Open the second screen
Navigator.pushNamed(
    context,
    "/second"
  );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants