set correct paths for ndll for linxuarm and linuxarm64 (raspberrypi) #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove conflicting legacy includepaths in build.xml
|
8.2.0-Dev has already been merged into develop, for the upcoming release, so I changed the base branch of this PR to match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set correct paths for ndll for linxuarm and linuxarm64 (raspberrypi)
and remove conflicting legacy includepaths in build.xml
These are the changes I made which allow compilation on a raspberry pi 4 or 5 running 32 or 64bit Bullseye or Bookworm (raspberrypios). A lot of the
isRaspberryPistatements have been replaced by checking for Arm64 or Armv7 so that in the future other linux arm boards could be used as well. Ndlls are built in ndll/LinuxArm and ndll/LinuxArm64 instead of the previous ndll/RPi pathOld -I flags have been removed from Build.xml because they point to libraries from older OS versions and do no longer exist on bullseye and bookworm. They prevented sdl from compiling on these os versions.
Performance on older versions of the raspberrypi was poor. So I think support should be for pi4 and up only.
SDL still has pi specific code.
That's why a -Drpi flag can still be found when calling hxcpp. Otherwise a build would fail.
One important note is that for 64bit the latest (git)build of hxcpp is needed ! There is a bug in haxelibversion that caused threads to throw a bus error. This is solved in master.