Implement controller rumble support to ui/Gamepad #1739
Conversation
|
I've tested this as working! |
| gameController = other.gameController; | ||
| other.gameController = temp; | ||
| return *this; | ||
| } |
There was a problem hiding this comment.
Wouldn't it be clearer to define a Swap() function instead of overriding an operator?
There was a problem hiding this comment.
was this the final thing that needed to be addressed for this PR?
There was a problem hiding this comment.
I don't know about "final" or otherwise. This was just something I was curious about.
There was a problem hiding this comment.
fwiw, op overloading does seem to make, otherwise seemingly straightforward code have oddly obfuscated behavior
* whitespacing real.. please! * nativecffi rumble thing fix lol
|
many of the whitespacing/formatting issues should be fixed up now @player-03 and the changes should be easier to parse through and read! |
|
Any updates on this? |
|
im not op (but I paid him for this mini series of PRs!) but were there any particular blockers to this gamepad rumble PR? |
|
Yeah, it needs to go into the 8.3-dev branch not develop. I'll try to test and see about merging it before the end of the weekend. |
|
I'm still not convinced the operator overload is the correct implementation, but I'm glad to have someone else look at it. |
This PR adds a controller rumble method to the ui/Gamepad class.
At this time, it only implements the native/SDL2 backend. HTML5 should be simple as well, although browser support for rumble is lacking as of writing this.
Closes #869