Optional codepath quotes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think it should check for spaces instead, and quote only if spaces are included? |
|
That's a good point, just sort of went with the first thing which worked. Seems like a better way to do it, so I just switched it over to that. |
|
Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This small change allows you to opt out of code paths being surrounded by quotes. My reason for wanting this is to work around a bug in lix where it fails to read code paths surrounded by quotes (lix-pm/haxeshim#32).
I've been using my own hxp fork for around 6 months now where the only change is removing code path quoting, but I thought I'd finally get around to making a PR for it to be opt out so I don't have to keep my own fork up to date.
Cheers.