Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Pypi token #292

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Switch to Pypi token #292

merged 7 commits into from
Feb 16, 2024

Conversation

benoit-cty
Copy link
Contributor

@benoit-cty benoit-cty commented Feb 13, 2024 •
edited
Loading

Technical changes

@benoit-cty
Copy link
Contributor Author

@sandcha must check if this is the good variable regarding the github settings.

sandcha
sandcha approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@sandcha sandcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @benoit-cty for the fix! I recommend updating the token name (see suggestions) before merging this PR 🙂

.github/workflows/workflow.yml Outdated Show resolved Hide resolved
.github/workflows/workflow.yml Outdated Show resolved Hide resolved
@benoit-cty benoit-cty merged commit 9c3fe26 into master Feb 16, 2024
10 checks passed
@benoit-cty benoit-cty deleted the switch-to-pypi-token branch February 16, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandcha sandcha sandcha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoit-cty @sandcha