Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrige nom arguments calmar #285

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Corrige nom arguments calmar #285

merged 4 commits into from
Mar 25, 2024

Conversation

sylvainipp
Copy link
Contributor

Technical changes

  • Some arguments were not consistently named.

@sylvainipp sylvainipp marked this pull request as draft January 25, 2024 11:12
benjello
benjello approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a bit of doubt about the lo parameter, but I trust you checked carefully.

@benjello
Copy link
Member

If you have time, it could be helpful if you can add a test that would have surfaced this error so other refactoring exercise would produce such errors.

@sylvainipp sylvainipp marked this pull request as ready for review January 26, 2024 08:53
@sylvainipp sylvainipp merged commit f78ef85 into master Mar 25, 2024
10 checks passed
@sylvainipp sylvainipp deleted the corrige_calmar branch April 4, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjello benjello benjello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sylvainipp @benjello