Pote #259
Merged
Pote #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-cty
approved these changes
Aug 8, 2024
openfisca_france_data/pote/input_data_builder/before_script_pote_sas_to_parquet.py
Show resolved
Hide resolved
openfisca_france_data/pote/input_data_builder/before_script_pote_sas_to_parquet.py
Show resolved
Hide resolved
openfisca_france_data/pote/input_data_builder/step_02_b_simulation_credits_reductions.py
Outdated
Show resolved
Hide resolved
| survey_name: str = None, | ||
| batch_size: int = None, | ||
| batch_index: int = 0, | ||
| filter_by = None, # [(f'foyer_fiscal_id', 'in', [i for i in range(batch_size*batch_index,(batch_size*batch_index) + batch_size)])] |
There was a problem hiding this comment.
Oui je pense que c'est bien de le garder ça donne un exemple de comment doit être le filter_by
| self.used_as_input_variables = var_to_keep + var_create_in_custom_input_data_frame | ||
| else: | ||
| self.used_as_input_variables = used_as_input_variables | ||
| #print("Données du scenario : \n", data) |
| self.init_from_data( | ||
| data=data, | ||
| rebuild_input_data=rebuild_input_data, | ||
| #config_files_directory=data["config_files_directory"] |
| @@ -58,8 +59,8 @@ | |||
| "pypandoc", | |||
| 'pytest >=7.2.2, <8.0', | |||
| "scipy >=1.2.1, <2.0.0", | |||
| "toolz >=0.9.0, <1.0.0", | |||
| ], | |||
There was a problem hiding this comment.
La convention en Python est plutôt de laisser les virgules sur les derniers éléments : https://stackoverflow.com/a/17002144
Co-authored-by: Benoit Courty <[email protected]>
Co-authored-by: Benoit Courty <[email protected]>
Co-authored-by: Benoit Courty <[email protected]>
…te_sas_to_parquet.py Co-authored-by: Benoit Courty <[email protected]>
…tion_credits_reductions.py Co-authored-by: Benoit Courty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features
/openfisca_france_data/pote/