Allow non-integral inputs to int variables #780
Conversation
There was a problem hiding this comment.
I'm assuming the issue appeared while running a YAML test, as this is the only place where Core uses scenarios.
That makes the functional scope of this PR is included in #781, as that PR will make Core stop using scenarios, and therefore accepts float for int values in YAML tests too.
Depending on how urgent this PR is, I'll let you judge if it's worth merging it before #781, or closing it. In all case, the changelog should clearly mention that this PR only brings changes for YAML tests.
| @@ -178,3 +178,11 @@ def test_set_not_chaged_variable(): | |||
| array = np.asarray([2000]) | |||
| holder.set_input('2015-01', array) | |||
| assert_equal(simulation.calculate('salary', '2015-01'), array) | |||
|
|
|||
|
|
|||
| def test_set_input_float_to_int(): | |||
There was a problem hiding this comment.
This tests pass without the change on columns.py 😅
(tests in this file don't use scenarios)
There was a problem hiding this comment.
Yep, that's on purpose - documenting at what level the desired behaviour is being blocked.
|
It's not very urgent, but it allows us to close #463 right away with a clean conscience. |
Morendil
force-pushed
the
float-inputs-to-ints
branch
from
aeb7d73
to
4aaed75
Compare
Fixes #463
Technical changes
The unit test included in this PR shows that a Holder will happily accept an array of float as an input to an
intvariable.The underlying cause here is that parsing test cases still relies on
scenarioswhich we would like to drop support for, per #716. Scenarios in turn rely oncolumns, of which the code says they are "considered deprecated". Columns and scenarios rely onconv, which I understand is our main remaining link with Biryani. We have been saying for a while that we intend to drop Biryani, e.g. #691.This looks like a textbook case for applying the Mikado Method. ;)