Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: cleanup entities #1286

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

BREAKING CHANGE: cleanup entities #1286

wants to merge 9 commits into from

Commits on Oct 25, 2024

  1. test: fix broken yaml tests

    @bonjourmauko
    bonjourmauko committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    bec66af View commit details
    Browse the repository at this point in the history

  2. BREAKING CHANGE: remove CoreEntity.check_role_validity 

    The method in itself had no relation to `entities` (it was a static
method, so no depending neither on an entity class nor an instance). It
could have been kept as a `populations` helper, where it was exclusively
used. Nonetheless, `check_role_validity` had the peculiar behaviour of
not failing but when the value of `role` is not `None`, that granted it
in my opinion the right to be removed so as to avoid confusion.
    @bonjourmauko
    bonjourmauko committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    85e939d View commit details
    Browse the repository at this point in the history

  3. BREAKING CHANGE: remove class_override arg from `entities.build_ent… 

    …ity`

That argument actually did nothing, and linters have been complaining
about this argument for almost 10 years now. It is only being marked as
a breaking change for respect to the semantic versioning protocol.
    @bonjourmauko
    bonjourmauko committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2fe9d10 View commit details
    Browse the repository at this point in the history

  4. BREAKING CHANGE: remove CoreEntity.set_tax_benefit_system 

    The feature is now provided by simple variable assignment:

```python
entity.tax_benefit_system = tax_benefit_system
```

Likewise, `entity.tax_benefit_system` becomes part of the public API
(which implicitly it was as the private marker was being violated).
    @bonjourmauko
    bonjourmauko committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6af247e View commit details
    Browse the repository at this point in the history

  5. feat: add CoreEntity.variables

    @bonjourmauko
    bonjourmauko committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a3cd58d View commit details
    Browse the repository at this point in the history

  6. refactor: make CoreEntity.get_variable reuse .variables

    @bonjourmauko
    bonjourmauko committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8f04683 View commit details
    Browse the repository at this point in the history

  7. BREAKING CHANGE: remove CoreEntity.check_variable_defined_for_entity 

    The feature is still provided by `CoreEntity.get_variable` when passed
the optional positional or keyword argument `check_existence`. In fact,
the removed method was duplicating and already existing behaviour.
    @bonjourmauko
    bonjourmauko committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a0b026f View commit details
    Browse the repository at this point in the history

  8. chore: version bump

    @bonjourmauko
    bonjourmauko committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9d5cfc7 View commit details
    Browse the repository at this point in the history

  9. build(conda): update openfisca-extension-template

    @bonjourmauko
    bonjourmauko committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    1011e8b View commit details
    Browse the repository at this point in the history