Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve commons module typing #1219

Merged
merged 7 commits into from
Sep 18, 2024
Merged

refactor: improve commons module typing #1219

merged 7 commits into from
Sep 18, 2024

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Sep 16, 2024 •
edited
Loading

Fixes #1230
Depends on #1218
Depended upon by #1146

Technical changes

  • Fix doc & type definitions in the commons module

@bonjourmauko bonjourmauko added level:intermediate Requires average OpenFisca experience kind:refactor Refactoring and code cleanup labels Sep 16, 2024
@bonjourmauko bonjourmauko requested review from a team September 16, 2024 00:24
@bonjourmauko bonjourmauko self-assigned this Sep 16, 2024
@coveralls
Copy link

coveralls commented Sep 16, 2024 •
edited
Loading

Coverage Status

coverage: 74.675% (-0.2%) from 74.843%
when pulling 5aaca86 on fix-mypy-checks
into bbc402f on master.

Base automatically changed from fix-flake8-doc-styles to master September 16, 2024 10:48
@bonjourmauko bonjourmauko force-pushed the fix-mypy-checks branch 2 times, most recently from 1c299cb to a694d28 Compare September 16, 2024 23:07
@bonjourmauko bonjourmauko added level:starter Suited for beginners and new contributors and removed level:intermediate Requires average OpenFisca experience labels Sep 16, 2024
@bonjourmauko bonjourmauko changed the title Fix some mypy checks Fix doc & type definitions in the commons module Sep 16, 2024
@bonjourmauko bonjourmauko mentioned this pull request Sep 16, 2024
Merged
benjello
benjello reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@benjello benjello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not well equiped to review this PR @bonjourmauko

@bonjourmauko bonjourmauko changed the title Fix doc & type definitions in the commons module [1bis/17] Improve commons module typing Sep 17, 2024
@bonjourmauko bonjourmauko merged commit 77cc91f into master Sep 18, 2024
22 checks passed
@bonjourmauko bonjourmauko deleted the fix-mypy-checks branch September 18, 2024 11:00
@bonjourmauko bonjourmauko mentioned this pull request Sep 18, 2024
Open
17 tasks
@bonjourmauko bonjourmauko mentioned this pull request Sep 25, 2024
Closed
@bonjourmauko bonjourmauko changed the title [1bis/17] Improve commons module typing refactor: improve commons module typing Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjello benjello benjello approved these changes

@Morendil Morendil Awaiting requested review from Morendil

@MattiSG MattiSG Awaiting requested review from MattiSG

@guillett guillett Awaiting requested review from guillett

@benoit-cty benoit-cty Awaiting requested review from benoit-cty

@sandcha sandcha Awaiting requested review from sandcha

Assignees

@bonjourmauko bonjourmauko

Labels
kind:refactor Refactoring and code cleanup level:starter Suited for beginners and new contributors
Projects
OpenFisca International
Archived in project
Milestone
Improved doc, style & linting
Development

Successfully merging this pull request may close these issues.

Add typing to commons
3 participants
@bonjourmauko @coveralls @benjello