-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniformize tests with the new API #18
Conversation
f3f446d
to
59df1b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as in openfisca/country-template#66: from a user's perspective, it is a breaking change IMHO.
Could you elaborate on why this is a breaking change? What use-case are you thinking about? I guess we could consider that a BC if we consider that users can run tests of their own that are not part of the package 🤔 |
Would you have time to suggest or add a few commits to make this PR acceptable? |
Hi @fpagnoux, I was thinking by the contributor point of view, but I'm now convinced it is a minor. Go ! |
52f9796
to
3c1aa8e
Compare
Connected to openfisca/openfisca-core#716