Uniformize tests with the new API #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpagnoux
force-pushed
the
uniformize-tests-api
branch
2 times, most recently
from
f3f446d
to
59df1b8
Compare
bonjourmauko
reviewed
Dec 5, 2018
bonjourmauko
requested changes
Dec 5, 2018
There was a problem hiding this comment.
Same as in openfisca/country-template#66: from a user's perspective, it is a breaking change IMHO.
|
Could you elaborate on why this is a breaking change? What use-case are you thinking about? I guess we could consider that a BC if we consider that users can run tests of their own that are not part of the package 🤔 |
|
Would you have time to suggest or add a few commits to make this PR acceptable? |
|
Hi @fpagnoux, I was thinking by the contributor point of view, but I'm now convinced it is a minor. Go ! |
bonjourmauko
approved these changes
Dec 5, 2018
bonjourmauko
reviewed
Dec 5, 2018
fpagnoux
force-pushed
the
uniformize-tests-api
branch
from
52f9796
to
3c1aa8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to openfisca/openfisca-core#716