Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup script #163

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Fix setup script #163

merged 3 commits into from
Jan 9, 2025

Conversation

jganseman
Copy link
Contributor

  • Crash fix.
  • Impacted areas: ./first-time-setup.sh
  • Details:
    • Remove mention of .flake8 which crashes setup script when not present

These changes :

  • Fix or improve an already existing calculation --> setup script.

@jganseman jganseman mentioned this pull request Jan 6, 2025
Closed
MattiSG
MattiSG approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@MattiSG MattiSG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MattiSG MattiSG enabled auto-merge January 6, 2025 21:44
@MattiSG MattiSG linked an issue Jan 6, 2025 that may be closed by this pull request
First time setup failed and made this repo hard to use from scratch #160
Closed
@MattiSG MattiSG changed the title Fix #162 Fix setup script Jan 6, 2025
@MattiSG
Copy link
Member

MattiSG commented Jan 6, 2025

We just need to bump the version number (patch bump) and update the CHANGELOG.

auto-merge was automatically disabled January 7, 2025 17:40

Head branch was pushed to by a user without write access

jganseman
jganseman commented Jan 7, 2025
View reviewed changes
Copy link
Contributor Author

@jganseman jganseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog and version updated

@benjello benjello merged commit a8628c5 into openfisca:main Jan 9, 2025
6 checks passed
@jganseman jganseman deleted the patch-162 branch January 10, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattiSG MattiSG MattiSG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First time setup failed and made this repo hard to use from scratch
3 participants
@jganseman @MattiSG @benjello