-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Training upgrade #139
Merged
Merged
Training upgrade #139
Changes from 25 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
9f0b08c
Major proposed update to country template, introduces pyproject.toml …
verbman 0ba2296
Allow for versions of python >= 3.9
verbman 49726ba
Adjustment to allow OpenFisca-core tests to find repository
verbman 8c54f5e
Update CHANGELOG.md
verbman 08141e8
Resolution for issue 116 regarding changelog entries
verbman d761ec5
First response to review, quiet git commits in bootstrap.sh, not add …
verbman 600f986
Bootstrap.sh and readme.md updates to improve flow for first users.
verbman d96b2f3
Disable line-length rule in yamllint, update README.md to include pip…
verbman b7b130f
Update pyproject.toml on install to switch from Production/Stable to …
verbman d0c1ffc
CHANGELOG.md updates
verbman 4db6df3
Apply suggestions from code review
verbman ef71696
Snakecase and while improvements to bootstrap
verbman 0d309ed
Apply suggestions from code review
verbman f38f8f9
Possible diacritics resolution, simplified bootstrap.sh file and READ…
verbman 188ecd5
Support env variables in bootstrap.sh
MattiSG 875d55d
Bring backwards compatibility to env variables
MattiSG 061900c
Fix casing and improve phrasings
MattiSG 7cdc8bc
Support spaces in jurisdiction name
MattiSG 3fe43ce
Remove unnecessary options
MattiSG de24fb4
Do not create a new shell session on bootstrap
MattiSG ae5842a
Fix whitespace
MattiSG 363ecd0
Unify conditions syntax
MattiSG 40819d5
Automatically set up remote
MattiSG 225d206
Make example changelog entry directly usable
MattiSG 3456cb6
Simplify changelog entry
MattiSG 4c842be
Remove unneeded command from bootstrap
verbman 8839eef
Remove counter-productive automatic remote setup
MattiSG 25f0e43
Add comment to keep non-interactive usage
MattiSG 7c38ece
Add Windows compatibility note
MattiSG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
[flake8] | ||
hang-closing = true | ||
ignore = D101,D102,D103,D107,D401,E128,E251,E501,W503 | ||
in-place = true | ||
inline-quotes = " | ||
multiline-quotes = """ | ||
import-order-style = appnexus | ||
no-accept-encodings = true | ||
application-import-names = openfisca_country_template | ||
application-package-names = openfisca_core | ||
exclude = .git,__pycache__,.venv,.github,.devcontainer,docs | ||
|
||
; D101: Variables already provide label/description | ||
; D102/103: Do not document methods/functions | ||
; D107: Do not document __init__ method | ||
; D401: Do not require the imperative mood | ||
; E128/133: Prefer hang-closing visual indents | ||
; E251: Prefer `function(x = 1)` over `function(x=1)` | ||
; E501: Do not enforce a maximum line length | ||
; W503/4: Break lines before binary operators (Knuth's style) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
|
||
extends: relaxed | ||
|
||
rules: | ||
line-length: disable |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any breaking change, so according to semver this could just be a minor 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the breaking change discussed between this and OpenFisca-Core tests...