Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Composite Scaling Technique Mode (#910 phase 1) #928

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

fdiasmor
Copy link
Collaborator

@fdiasmor fdiasmor commented Jan 3, 2025

No description provided.

@fdiasmor fdiasmor requested a review from yspolyakov January 3, 2025 02:34
@fdiasmor fdiasmor self-assigned this Jan 3, 2025
@fdiasmor fdiasmor linked an issue Jan 3, 2025 that may be closed by this pull request
@yspolyakov yspolyakov added the new feature New feature or request label Jan 5, 2025
@yspolyakov yspolyakov added this to the Release 1.3.0 milestone Jan 5, 2025
@yspolyakov
Copy link
Contributor

The CI does not work correctly. Please see https://github.com/openfheorg/openfhe-development/actions/runs/12592180329 This should run for 32, 64, and 128-bit CI's,

Copy link
Contributor

@yspolyakov yspolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the note + CI problem.

src/pke/include/scheme/ckksrns/ckksrns-cryptoparameters.h Outdated Show resolved Hide resolved
src/pke/include/scheme/gen-cryptocontext-params-defaults.h Outdated Show resolved Hide resolved
src/pke/include/schemerns/rns-cryptoparameters.h Outdated Show resolved Hide resolved
src/pke/include/schemerns/rns-cryptoparameters.h Outdated Show resolved Hide resolved
src/pke/lib/scheme/ckksrns/ckksrns-cryptoparameters.cpp Outdated Show resolved Hide resolved
src/pke/lib/scheme/ckksrns/ckksrns-parametergeneration.cpp Outdated Show resolved Hide resolved
src/pke/lib/scheme/ckksrns/ckksrns-parametergeneration.cpp Outdated Show resolved Hide resolved
src/pke/lib/scheme/ckksrns/ckksrns-leveledshe.cpp Outdated Show resolved Hide resolved
src/pke/lib/scheme/ckksrns/ckksrns-cryptoparameters.cpp Outdated Show resolved Hide resolved
@fdiasmor
Copy link
Collaborator Author

fdiasmor commented Jan 8, 2025

The CI does not work correctly. Please see https://github.com/openfheorg/openfhe-development/actions/runs/12592180329 This should run for 32, 64, and 128-bit CI's,

Fixed in latest commit c8c76a8.

@fdiasmor
Copy link
Collaborator Author

The CI does not work correctly. Please see https://github.com/openfheorg/openfhe-development/actions/runs/12592180329 This should run for 32, 64, and 128-bit CI's,

It passes after latest commits 4b721d9, a5a443a, and b14472d. (see job run)

@fdiasmor fdiasmor changed the title #910 Add Composite Scaling Technique Mode Add Composite Scaling Technique Mode (phase 1) Jan 10, 2025
@fdiasmor fdiasmor changed the title Add Composite Scaling Technique Mode (phase 1) Add Composite Scaling Technique Mode (#910 phase 1) Jan 10, 2025
Copy link
Collaborator

@dsuponitskiy dsuponitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dsuponitskiy dsuponitskiy merged commit 393bc77 into dev Jan 14, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CKKS Composite Scaling
3 participants