Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(java): Add Java integration tests #160

Merged
merged 15 commits into from
Aug 2, 2023
Merged

test(java): Add Java integration tests #160

merged 15 commits into from
Aug 2, 2023

Conversation

booniepepper
Copy link
Contributor

@booniepepper booniepepper commented Jul 27, 2023 •
edited
Loading

Description

Adds integration tests to the Java SDK

I plan to mark this as ready for review after these are complete:

  • GitHub CI (Pending some offline work to enable this)
  • Basic happy paths are covered (getting there, need to finish more)

(Currently, a Java SDK is in development on a feature branch. Progress on the Java integration can be seen on #158)

References

Closes #153

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

booniepepper
booniepepper commented Jul 27, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@booniepepper booniepepper force-pushed the test/java-integ-tests branch 3 times, most recently from 9dbe888 to 17bc284 Compare July 31, 2023 23:30
@booniepepper booniepepper marked this pull request as ready for review August 1, 2023 00:54
@booniepepper booniepepper requested a review from a team as a code owner August 1, 2023 00:54
rhamzeh
rhamzeh reviewed Aug 1, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@booniepepper booniepepper force-pushed the test/java-integ-tests branch 3 times, most recently from 18df6cc to bf7cefb Compare August 1, 2023 18:51
@booniepepper booniepepper requested a review from rhamzeh August 1, 2023 18:54
booniepepper and others added 12 commits August 1, 2023 13:04
@booniepepper
test(java): Add Java integration tests
c01b950
@booniepepper
test(java): Split integ tests from unit tests, add more tests
79958b1
@booniepepper
test(java): Split make target for integration tests out from unit tests
76b91f5
@booniepepper
refactor(java): Consolidate a single function utility class into the …
2b6ef15 
…only calling test class
@booniepepper
test(java): Add integ test on writeAuthorizationModel
ce0d66a
@booniepepper
test(java): Add integ test for write/read
01594cc
@booniepepper
test(java): Add integ tests for check/expand/listObjects
c4af9cc
@booniepepper
test(java): Add integ tests for readAuthorizationModel(s)
92235f9
@booniepepper
test(java): Add integ tests for writeAssertions/readAssertions
4edc6fb
@booniepepper
test(java): Add integ test for readChanges
c903065
@booniepepper @rhamzeh
clean(java): Remove redundant build in Makefile
33e5d42 
Co-authored-by: Raghd Hamzeh <[email protected]>
@booniepepper
refactor(java): Minor updates after rebase
ef50c7b
@booniepepper booniepepper force-pushed the test/java-integ-tests branch from bf7cefb to ef50c7b Compare August 1, 2023 20:05
@booniepepper booniepepper requested review from adriantam and removed request for rhamzeh August 1, 2023 20:21
@booniepepper booniepepper force-pushed the test/java-integ-tests branch 17 times, most recently from 234bfa0 to ed84f6e Compare August 1, 2023 23:47
@booniepepper booniepepper force-pushed the test/java-integ-tests branch from ed84f6e to ef88f02 Compare August 1, 2023 23:49
adriantam
adriantam approved these changes Aug 2, 2023
View reviewed changes
.github/workflows/main.yaml Show resolved Hide resolved
@booniepepper booniepepper mentioned this pull request Aug 2, 2023
Open
@booniepepper booniepepper merged commit 849f2a2 into feat/java-sdk Aug 2, 2023
@booniepepper booniepepper deleted the test/java-integ-tests branch August 2, 2023 16:22
This was referenced Aug 3, 2023
Closed
Closed
Merged
@booniepepper booniepepper mentioned this pull request Aug 18, 2023
Merged
4 tasks
booniepepper added a commit that referenced this pull request Aug 25, 2023
@booniepepper @rhamzeh
test(java): Add Java integration tests (#160)
462e135 
Adds integration tests for the Java SDK

For intermediate commit details, see #160

---------

Co-authored-by: Raghd Hamzeh <[email protected]>
booniepepper added a commit that referenced this pull request Aug 25, 2023
@booniepepper @rhamzeh
test(java): Add Java integration tests (#160)
9edd375 
Adds integration tests for the Java SDK

For intermediate commit details, see #160

---------

Co-authored-by: Raghd Hamzeh <[email protected]>
booniepepper added a commit that referenced this pull request Sep 6, 2023
@booniepepper @rhamzeh
test(java): Add Java integration tests (#160)
bea9236 
Adds integration tests for the Java SDK

For intermediate commit details, see #160

---------

Co-authored-by: Raghd Hamzeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh left review comments

@adriantam adriantam adriantam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@booniepepper @rhamzeh @adriantam