-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: list_users
should accept FgaObject
type
#99
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 68.06% 68.07% +0.01%
==========================================
Files 114 114
Lines 8974 8969 -5
==========================================
- Hits 6108 6106 -2
+ Misses 2866 2863 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could we also update the readme docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the README and the example too?
…ithub.com/openfga/python-sdk into fix/list_users-accept-fgaobject-for-users
@rhamzeh @ewanharris Updated, thanks! |
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
The merge-base changed after approval.
Description
This pull request fixes the
ClientListUsersRequest
class, which incorrectly accepts astr
type forobject
rather than anFgaObject
assignment. For consistency's sake, it also improves the type hinting of the other class properties.References
list_users
should accept aFgaObject
type for theusers
parameter #97Review Checklist
main