Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list_users should accept FgaObject type #99

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

evansims
Copy link
Member

Description

This pull request fixes the ClientListUsersRequest class, which incorrectly accepts a str type for object rather than an FgaObject assignment. For consistency's sake, it also improves the type hinting of the other class properties.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (664b0b9) to head (359ea33).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   68.06%   68.07%   +0.01%     
==========================================
  Files         114      114              
  Lines        8974     8969       -5     
==========================================
- Hits         6108     6106       -2     
+ Misses       2866     2863       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims marked this pull request as ready for review June 13, 2024 05:43
@evansims evansims requested a review from a team as a code owner June 13, 2024 05:43
Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could we also update the readme docs?

Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the README and the example too?

@evansims evansims requested review from a team as code owners June 14, 2024 04:57
@evansims evansims requested review from rhamzeh and ewanharris June 14, 2024 05:00
@evansims
Copy link
Member Author

@rhamzeh @ewanharris Updated, thanks!

@evansims evansims enabled auto-merge June 14, 2024 05:06
rhamzeh
rhamzeh previously approved these changes Jun 14, 2024
@evansims evansims dismissed rhamzeh’s stale review June 14, 2024 10:03

The merge-base changed after approval.

rhamzeh
rhamzeh previously approved these changes Jun 14, 2024
@github-merge-queue github-merge-queue bot dismissed rhamzeh’s stale review June 14, 2024 10:05

The merge-base changed after approval.

rhamzeh
rhamzeh previously approved these changes Jun 14, 2024
@evansims evansims dismissed rhamzeh’s stale review June 14, 2024 10:11

The merge-base changed after approval.

ewanharris
ewanharris previously approved these changes Jun 14, 2024
@evansims evansims dismissed ewanharris’s stale review June 14, 2024 11:31

The merge-base changed after approval.

@evansims evansims added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit b033cb0 Jun 14, 2024
10 of 12 checks passed
@evansims evansims deleted the fix/list_users-accept-fgaobject-for-users branch June 14, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list_users should accept a FgaObject type for the users parameter
4 participants