Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ReadAuthorizationModel calls from BatchCheck and writes #98

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

evansims
Copy link
Member

Description

This pull request removes the ReadAuthorizationModel calls in BatchCheck and writes.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims force-pushed the fix/dont-read-model-on-batch-check branch from 030cd24 to 34de388 Compare June 13, 2024 05:23
@evansims evansims force-pushed the fix/dont-read-model-on-batch-check branch from 34de388 to c09d97d Compare June 13, 2024 05:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.06%. Comparing base (664b0b9) to head (c09d97d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   68.06%   68.06%           
=======================================
  Files         114      114           
  Lines        8974     8968    -6     
=======================================
- Hits         6108     6104    -4     
+ Misses       2866     2864    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims marked this pull request as ready for review June 13, 2024 05:26
@evansims evansims requested a review from a team as a code owner June 13, 2024 05:26
@evansims evansims added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit 82b1202 Jun 13, 2024
17 checks passed
@evansims evansims deleted the fix/dont-read-model-on-batch-check branch June 13, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants