Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support list users #94

Merged
merged 1 commit into from
Jun 6, 2024
Merged

feat: support list users #94

merged 1 commit into from
Jun 6, 2024

Conversation

evansims
Copy link
Member

@evansims evansims commented Jun 5, 2024

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims added the enhancement New feature or request label Jun 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 59.22990% with 360 lines in your changes missing coverage. Please review.

Project coverage is 68.06%. Comparing base (5a5e26c) to head (f410a6a).

Files Patch % Lines
openfga_sdk/models/object_or_userset.py 34.92% 41 Missing ⚠️
...k/models/unprocessable_content_message_response.py 34.92% 41 Missing ⚠️
openfga_sdk/models/unauthenticated_response.py 46.03% 34 Missing ⚠️
openfga_sdk/models/list_users_response.py 52.30% 31 Missing ⚠️
...fga_sdk/models/unprocessable_content_error_code.py 36.73% 31 Missing ⚠️
openfga_sdk/models/userset_user.py 58.66% 31 Missing ⚠️
openfga_sdk/models/fga_object.py 53.84% 30 Missing ⚠️
openfga_sdk/models/list_users_request.py 70.58% 30 Missing ⚠️
openfga_sdk/models/typed_wildcard.py 47.27% 29 Missing ⚠️
openfga_sdk/models/user.py 61.11% 28 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   69.02%   68.06%   -0.97%     
==========================================
  Files         102      114      +12     
  Lines        8091     8974     +883     
==========================================
+ Hits         5585     6108     +523     
- Misses       2506     2866     +360     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims marked this pull request as ready for review June 5, 2024 03:12
@evansims evansims requested review from a team as code owners June 5, 2024 03:12
Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @evansims! I've just the comment around the readme content but otherwise it looks good to me.

@evansims evansims enabled auto-merge June 6, 2024 05:18
@evansims evansims requested a review from ewanharris June 6, 2024 05:19
Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@evansims evansims added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit ca36899 Jun 6, 2024
17 checks passed
@evansims evansims deleted the feat/list-users branch June 6, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants