Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): fix transactions mode being reversed #60

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

jimmyjames
Copy link
Contributor

@jimmyjames jimmyjames commented Feb 29, 2024

Description

⚠️ This is a behavioral breaking change!

Currently the OpenFgaClient reverses the behavior of write transactions based on the disableTransactions flag. This PR fixes that, only sending batched write requests if disableTransactions == true.

This is a functional breaking change, since the value of disableTransactions was being used incorrectly, so now disableTransactions == true will actually batch requests, and disableTransactions == false will send one (transactional) request.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jimmyjames jimmyjames requested a review from a team as a code owner February 29, 2024 15:02
@jimmyjames jimmyjames added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 21c1805 Feb 29, 2024
19 checks passed
@jimmyjames jimmyjames deleted the fix-flipped-transactions branch February 29, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the client, the transaction modes are flipped
2 participants