This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Replaced loop checks with helm wait operation #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Gupta <[email protected]>
|
Sorry didn't see @viveksyngh took the issue in PR #89 closing it now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rishabh Gupta [email protected]
Description
This PR replaces loop checks with helm wait operations.
How Has This Been Tested?
Tested changes on a local cluster.
The zip file contains ofc-bootstrap binary compiled from this branch and includes scripts and templates. To test this branch extract the contents of zip and provide init.yaml (example) and then run
./ofc-bootstrapofc-bootstrap.zip
Addresses issue #86
Checklist:
I have:
git commit -s