chore: additional tidying and use ctx propogation to enable docker build cancellation #971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the execute package into the project to add the require context passing. This can be pulled back later once we are happy with the implementation.
Streamline some of the watch and local-run code to use the native Context object instead of the Cancel object.
Use a
WaitGroup
to ensure that each run of theonChange
is finished before starting the next invocation. This avoids a potential race-condition due tocmd
object being a shared pointer and the context being cancelled and replaced.Reduce the number of
FAAS_DEBUG
checks required for logging, by creating a shared logger package for this.Motivation and Context
This is mostly a continuation of Implement --watch for local-run with cancellation support #970
How Has This Been Tested?
I have manually tested this with the
local-run
Types of changes
Checklist:
git commit -s