Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api-key type #221

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Fix api-key type #221

merged 1 commit into from
Apr 21, 2020

Conversation

john-g-g
Copy link
Contributor

Fix a typo in the value of api-key used in the secrets example

Description

Motivation and Context

How Has This Been Tested?

Not tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

@derek
Copy link

derek bot commented Apr 21, 2020

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Signed-off-by: John Gerlock <[email protected]>
@derek derek bot removed the no-dco label Apr 21, 2020
@alexellis alexellis merged commit a085292 into openfaas:master Apr 21, 2020
@alexellis
Copy link
Member

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants