Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWPP-4991: Update to php8.3 #282

Open
wants to merge 6 commits into
base: 1.x
Choose a base branch
from
Open

EWPP-4991: Update to php8.3 #282

wants to merge 6 commits into from

Conversation

drishu
Copy link
Contributor

@drishu drishu commented Jan 31, 2025

OPENEUROPA-[Insert ticket number here]

Description

[Insert description here]

Change log

  • Added:
  • Changed:
  • Deprecated:
  • Removed:
  • Fixed:
  • Security:

Commands

[Insert commands here]

@kp77 kp77 self-requested a review February 14, 2025 08:40
Copy link

@kp77 kp77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drishu,

Looks good. This is not related to the update I think, but I had some issues with running phpunit tests on my local:

  1. I had fails when I just ran the tests according to the readme. I had to run the commands run in drone to pass them. Maybe this should be documented in the readme.
  2. After I fixed the fails, I had phpunit hung up on Drupal\Tests\oe_showcase\ExistingSiteJavascript\EditorTest::testFormatEditor() without any debug information. I could fix this by adding these 2 lines from drone.yml to the selenium service in docker.compose.yml.

Also, I have the following warning every time I run docker-compose:

WARN[0000] ./oe_showcase/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion

We could fix this by removing the version attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants