#35 Upgrade jackson-databind to 2.10.2 and bump version to alpha #36
Conversation
|
|
||
| public class JsonService { | ||
|
|
||
| private static final ObjectMapper jsonMapper = new ObjectMapper(); | ||
|
|
||
| private static final JsonMapper jsonMapper = new JsonMapper(); |
There was a problem hiding this comment.
Why the change to explicit JsonMapper? Unless we're need something specifically from the child implementation we normally keep a level of abstraction and go with the parent - as was there before. Further, you'll note this is the approach taken in most documentation and tutorials.
Unless there is a need, could we please change back?
There was a problem hiding this comment.
After reading the release notes / change log, I had thought it was more secure. However on re-reviewing the documentation, I only found a specific reference (below), but I can't go so far as to say it's a need. I'll flip it back.
From FasterXML/jackson-databind#2153 :
ObjectMapper will still exist, and may even be instantiated (more so with 2.10, less with 3.x), but usage should move over to specific mappers for 3.x.
There was a problem hiding this comment.
Ok, that's changed back now.
|
Since the change was made from @edalex-ian 's review, I'm going to go ahead and merge this. |
#35
Based on the changelog, I switched
ObjectMappertoJsonMapper. Didn't see anything else that would to be modified. Looks likedatabindis only used in a single class in the admin console launcher, and it's a fairly simple one at that.