Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/#342 create scenations one pipeline #345

Merged
merged 10 commits into from
Nov 26, 2024

Conversation

ClaraBuettner
Copy link

Deals with #342
It was running successfully for Schleswig-Holstein

Copy link

@CarlosEpia CarlosEpia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can be merged into dev.

@@ -198,7 +198,8 @@ def load_biogas_generators(scn_name):
)
target_file = Path(".") / "datasets" / "gas_data" / basename

urlretrieve(url, target_file)
if not target_file.is_file():

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our current setting, that would mean we should manually copy-paste the file before this task is executed (since the file is not online anymore), right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file is there, the task does not try to download it anymore. In case the file is not there, it still tries to download it. That way, I could use the copy-pasted file without any errors.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they replaced the file with a newer version (see #337 (comment))

)

if target.empty:
print(f"No PV rooftop in scenario {scenario}")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is necessary because we are getting a unique solar carrier for both solar ground-mounted and rooftop. Do you know if that will be corrected in the next models coming from Pypsa-eur?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fixed by pypsa-eur. But we could still keep the check in there, right?

@ClaraBuettner ClaraBuettner merged commit f6e6756 into dev Nov 26, 2024
2 checks passed
@ClaraBuettner ClaraBuettner deleted the features/#342-create-scenations-one-pipeline branch November 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants