-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/#342 create scenations one pipeline #345
Features/#342 create scenations one pipeline #345
Conversation
…year for the scenario path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR can be merged into dev.
@@ -198,7 +198,8 @@ def load_biogas_generators(scn_name): | |||
) | |||
target_file = Path(".") / "datasets" / "gas_data" / basename | |||
|
|||
urlretrieve(url, target_file) | |||
if not target_file.is_file(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our current setting, that would mean we should manually copy-paste the file before this task is executed (since the file is not online anymore), right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the file is there, the task does not try to download it anymore. In case the file is not there, it still tries to download it. That way, I could use the copy-pasted file without any errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they replaced the file with a newer version (see #337 (comment))
) | ||
|
||
if target.empty: | ||
print(f"No PV rooftop in scenario {scenario}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is necessary because we are getting a unique solar carrier for both solar ground-mounted and rooftop. Do you know if that will be corrected in the next models coming from Pypsa-eur?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be fixed by pypsa-eur. But we could still keep the check in there, right?
Deals with #342
It was running successfully for Schleswig-Holstein