Incorrect wind_oshore and rooftop installed capacity in eGon100RE

[CarlosEpia]

The wind_oshore and rooftop installed capacities are incorrect when running the eGon100RE scenario.

[ClaraBuettner]

The problems with wind_onshore and solar are fixed in #369. There were basically two problems: the task to set bus_ids was not executed and there was a spatial join of two geodataframes with different CRS, so nothing was joined correctly.

For solar_rooftop I discovered one issue when status2019 and eGon100RE are created in one run.
For future scenarios the task power_plants.pv_rooftop.pv-rooftop-per-mv-grid directly writes the generators into the etrago tables and does not add them to supply.egon_power_plants. This is different for status2019 where pv_rooftop plants are added to supply.egon_power_plants.
After the power_plants dataset the task fill_etrago_gen is executed. That one starts with deleting all entries in the etrago generators tables for carriers that are in the supply.egon_power_plants for all scenarios:

powerd-data/src/egon/data/datasets/fill_etrago_gen.py

Lines 261 to 274 in 4ca597c

	carrier_delete = list(power_plants.carrier.unique())
	if carrier_delete:
	db.execute_sql(
	f"""DELETE FROM
	{cfg['targets']['etrago_generators']['schema']}.
	{cfg['targets']['etrago_generators']['table']}
	WHERE carrier IN {*carrier_delete,}
	AND bus IN (
	SELECT bus_id FROM {cfg['sources']['bus']['schema']}.
	{cfg['sources']['bus']['table']}
	WHERE country = 'DE'
	AND carrier = 'AC')
	"""

So all solar_rooftop plants for eGon100RE are dropped and not inserted again since they are not in supply.egon_power_plants.

I don't know what is the best option to fix this. @CarlosEpia: Could you take a look at this when you are back at work?
For the run starting today, I will only create eGon100RE to avoid these problems.

[CarlosEpia]

I think we should delete per scenario only generators with carriers created in supply.egon_power_plants. Change done in f22b9d8.

[ClaraBuettner]

@CarlosEpia: Did you already check if the problem was solved?

[ClaraBuettner]

In the run with both scenarios, wind onshore is there now for both scenarios, but solar rooftop is missing for eGon100RE.
In the run with only eGon100RE, wind onshore and solar_rooftop are there.
So the problem seems to be still there.

But it looks like your commit/branch was never merged into the run-status2019-and-egon100 branch, at least it is not in the online version.

[CarlosEpia]

Right. The branch which corrects this was never merged. I just created the PR #394.

[ClaraBuettner]

The problem with deleted solar_rooftop plants when creating both scenarios was solved with 1ce28d9.
In a test run for Schleswig-Holstein, the capacities look good now.