Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/#450 add metadata kh #1122

Open
wants to merge 92 commits into
base: features/#450-add-metadata
Choose a base branch
from

Conversation

khelfen
Copy link
Contributor

@khelfen khelfen commented Mar 16, 2023

Fixes #450 partly . Depends on #568 .

Before merging into dev-branch, please make sure that

  • the CHANGELOG.rst was updated.
  • new and adjusted code is formated using black and isort.
  • the Dataset-version is updated when existing datasets are adjusted.
  • the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-branch.
  • the workflow is running successful in test mode.
  • the workflow is running successful in Everything mode.

@khelfen khelfen added the 📖 publication Publication of results (WebApp and OEP) label Mar 16, 2023
@khelfen khelfen self-assigned this Mar 16, 2023
@khelfen khelfen changed the base branch from dev to features/#450-add-metadata August 20, 2024 09:24
@khelfen
Copy link
Contributor Author

khelfen commented Aug 20, 2024

@ClaraBuettner in case of etrago_setup.py there were heavy merge conflicts. In that case I just used the file from your branch #568 since I didn't really change anything in that file.

@khelfen
Copy link
Contributor Author

khelfen commented Aug 20, 2024

Also, what did happen to the function oep_metadata_version? I think I need to replace it in my changes.

@ClaraBuettner
Copy link
Contributor

Also, what did happen to the function oep_metadata_version? I think I need to replace it in my changes.

I am sorry, but I can't remember what happened to that function. I had a brief look at the commit history of the file but couldn't find the commit that removed it or a version of the file in which the function still existed.

@khelfen khelfen force-pushed the features/#450-add-metadata-kh branch from 7400a0c to 990e544 Compare August 22, 2024 08:23
Copy link
Contributor

@ClaraBuettner ClaraBuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check every changed line of code, but it looks fine in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 publication Publication of results (WebApp and OEP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create metadata for existing datasets
8 participants