Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installed capacities plot function #1025

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

CarlosEpia
Copy link
Contributor

Fixes #763.

Before merging into dev-branch, please make sure that

  • [] the CHANGELOG.rst was updated.
  • [] new and adjusted code is formated using black and isort.
  • [] the Dataset-version is updated when existing datasets are adjusted.
  • [] the branch was merged into the
    continuous-integration/run-everything-over-the-weekend-branch.
  • [] the workflow is running successful in test mode.
  • [] the workflow is running successful in Everything mode.

@CarlosEpia CarlosEpia assigned CarlosEpia and Alonsoju95 and unassigned CarlosEpia Nov 7, 2022
@CarlosEpia
Copy link
Contributor Author

Hi @Alonsoju95 ,
Last week we experimented with some problems related to the plotting function you wrote. Therefore it was deleted from dev. We agreed with @ClaraBuettner on not using new libraries that are not part of setup.py now, in order to avoid dependencies problems in the future. I already made some changes to your branch, so please double-check that everything is working correctly. From now on you will be responsible for this PR, so please take a look at the checkpoints at the beginning of this page and proceed consequently. Let me know in case you have any questions.

@Alonsoju95
Copy link
Contributor

@CarlosEpia Hi Carlos! Ok! I saw that the lines for the osm were erased, I understand it is because of the dependencies. Do I have to find another way to draw an osm map in the plot?

@CarlosEpia
Copy link
Contributor Author

@CarlosEpia Hi Carlos! Ok! I saw that the lines for the osm were erased, I understand it is because of the dependencies. Do I have to find another way to draw an osm map in the plot?

It's not necessary. Just follow the steps to merge the PR. Keep in mind that you need to merge it into the current CI branch, but first I would check what's wrong with one of the Git checks (Codacy Static Code Analysis).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of new plots for eGon-data scenarios
2 participants