Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

420 feature implement database using test oep environment #426

Merged
merged 18 commits into from
Oct 1, 2024

Conversation

joda9
Copy link
Collaborator

@joda9 joda9 commented Sep 18, 2024

Description

This PR will load all the data from the toep database. The table names are loaded via the dictionary so the names are still found in the code and are translated to the table numbers in the oep.

Fixes #420

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • New and adjusted code is formatted using the pre-commit hooks
  • New and adjusted code includes type hinting now
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The Read the Docs documentation is compiling correctly
  • If new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.
  • I have added new features to the corresponding whatsnew file

@joda9 joda9 linked an issue Sep 18, 2024 that may be closed by this pull request
@joda9 joda9 requested a review from khelfen September 27, 2024 12:24
Copy link
Collaborator

@khelfen khelfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks good! I just added two little comments. I'm not sure if they make any sense, so feel free to ignore them if they don't :D Also, you can proceed with the merge after checking them out.

edisgo/tools/config.py Outdated Show resolved Hide resolved
edisgo/tools/config.py Show resolved Hide resolved
@joda9 joda9 merged commit 80c4948 into dev Oct 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement Database Using Test OEP Environment
2 participants