-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
420 feature implement database using test oep environment #426
Merged
joda9
merged 18 commits into
dev
from
420-feature-implement-database-using-test-oep-environment
Oct 1, 2024
Merged
420 feature implement database using test oep environment #426
joda9
merged 18 commits into
dev
from
420-feature-implement-database-using-test-oep-environment
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge dev into branch
This reverts commit 05ac62e.
…database-using-test-oep-environment
khelfen
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, looks good! I just added two little comments. I'm not sure if they make any sense, so feel free to ignore them if they don't :D Also, you can proceed with the merge after checking them out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will load all the data from the toep database. The table names are loaded via the dictionary so the names are still found in the code and are translated to the table numbers in the oep.
Fixes #420
Type of change
Please delete options that are not relevant.
Bug fix (non-breaking change which fixes an issue)Breaking change (fix or feature that would cause existing functionality to not work as expected)Checklist:
pre-commit
hooksI have made corresponding changes to the documentationIf new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.I have added new features to the corresponding whatsnew file