Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/minor improvements #398

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Features/minor improvements #398

merged 7 commits into from
Apr 24, 2024

Conversation

birgits
Copy link
Collaborator

@birgits birgits commented Apr 24, 2024

Description

This PR fixes/improves some minor issues:

  • Directory where logging is saved to was not created correctly
  • When line is added to equipment_changes, the number of parallel lines was not used but set to 1
  • Electricity demand profiles can now be obtained for status quo
  • github workflow is adapted so that now Linux tests are excluded from Windows test run

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • New and adjusted code is formatted using the pre-commit hooks
  • New and adjusted code includes type hinting now
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The Read the Docs documentation is compiling correctly
  • If new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.
  • I have added new features to the corresponding whatsnew file

@birgits birgits merged commit cb9307e into dev Apr 24, 2024
7 checks passed
@birgits birgits deleted the features/minor_improvements branch April 24, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant