Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dreaft of BPMN for cosmmoclmgrid #334

Merged
merged 6 commits into from
Aug 27, 2020

Conversation

gplssm
Copy link
Contributor

@gplssm gplssm commented Mar 19, 2020

fix #333

@gplssm
Copy link
Contributor Author

gplssm commented Mar 19, 2020

cosmoclmgrid must be created before supply data is imported and preprocessed. The script ego_dp_supply_add_coastdat_gid.sql updates power plant tables with location information from cosmoclmgrid.
Therefore, in the structure BPMN, cosmoclmgrid needs to be linked to supply preprocessing in #336.
In #335 don't forget to document ego_dp_supply_add_coastdat_gid.sql.

@gplssm gplssm marked this pull request as ready for review April 10, 2020 18:01
@gplssm gplssm requested a review from IlkaCu April 10, 2020 18:01
@gplssm
Copy link
Contributor Author

gplssm commented Aug 21, 2020

@IlkaCu, I completed the documentation here. I did

  • Adding the script ego_dp_supply_add_coastdat_gid.sql
  • Made sure that cosmoclm part is linked to supply part in the overview graphic

Could you please review?

I assign myself which means for me that I'm responsible for merging, once the review is done.

@gplssm gplssm self-assigned this Aug 21, 2020
@IlkaCu
Copy link
Member

IlkaCu commented Aug 26, 2020

It seems that script ego_dp_supply_add_coastdat_gid.sql is redundant and no integral part of the preprocessing.

  1. it accesses the outdated table coastdat.cosmoclmgrid
  2. column coastdat_gid is not (anymore) present in supply tables (e.g. model_draft.ego_dp_supply_res_powerplant), but replaced by w_id
  3. w_id is assigned to supply tables in the dataprocessing itself in ego_dp_powerflow_assignment_otgid.sql accessing table coastdat.cosmoclmgrid
  4. Table model_draft.ego_conv_powerplant_costdat_gid is not accessed in the dataprocessing or other preprocessing parts

Therefore I suggest to remove this script and adjust the BPMN accordingly.

@IlkaCu IlkaCu requested a review from ClaraBuettner August 27, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants