-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt database connection creator #123
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I never run the dp I cannot really test and thus review this PR. I think @ulfmueller and @Ludee are the ones that could do so.
@lukasol I think review by @ulfmueller and @Ludee is sufficient. Thx. |
Start testing now: |
creation of .egoio/config.ini works. |
Problem was that oemof.db has to be installed in the newest version (v0.0.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is complicated (three repos) with a lot of potential errors. But it works as desired.
A future job is to combine everything in oemof.db
Is this still part of MS Release v0.3 or do we move it to v0.3.1? @gplssm |
We move it because it requires work to be done in ego.powerflow |
The db access stuff is finished in openego/ego.io#34 and is ready for use. This PR might needs to be adapted.. |
This PR is pretty old and still open. @gplssm: Is it still relevant? |
To be honest, I suggest to re-start from scratch! Changes included in this PR are pretty small and not to innovative. Furthermore, these are quite outdated... |
I agree with @gplssm since in the meantime we created our own db connector in ego.io now without dependencies to oemof, we can use it like in the other apps (eTraGo, eDisGo and so on). Close this PR and create an issue? |
This branch provides OEDB connection establishment via ego.io own config file. If this config file does not exist, it should be interactively be created (the computer will ask you ;-) ).
This new functionality relies of methods available in "features/own-config-file" of ego.io. Please use this branch to test this PR. Once, the PR is merged we need a new ego.io Release. I suggest to make a 0.2.1 release
For the reviewers, please check if the data_processing script still runs and everything works like normal/expected.