Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set height of lti modal to 100% not auto #460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ilee2u
Copy link
Contributor

@ilee2u ilee2u commented Mar 28, 2024

TICKET: https://2u-internal.atlassian.net/browse/COSMO-227

It seems the css for the height of an LTI modal's iframe was set to "auto" (which seemed to be defaulting to 100vh), not 100%, which seems to have caused issues for some learners on iPads.

NOTE: I have yet to test this locally and I'm not sure I can, especially given that we can't use the IMS global to anymore.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.83%. Comparing base (1de6fa7) to head (e9bb1b2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files          77       77           
  Lines        6710     6710           
=======================================
  Hits         6565     6565           
  Misses        145      145           
Flag Coverage Δ
unittests 97.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feanil
Copy link
Contributor

feanil commented Dec 12, 2024

@Faraz32123 can you review and test this PR? I know you don't currently have write access but it would be great for you to still review these PRs and tag me if you think they are okay to merge.

@Faraz32123
Copy link

@Faraz32123 can you review and test this PR? I know you don't currently have write access but it would be great for you to still review these PRs and tag me if you think they are okay to merge.

@feanil It'll be great. I'll sure review and test this PR and mention you.
Plus I think I can gradually start look at other issues as well instead of waiting to get write access. Will mention you on those as well.

@Faraz32123
Copy link

hello @ilee2u,
regarding this issue, as u said it's on the learner side(LMS) occurred for some learners on iPads.
I have tested it in the browser using Ipad resolution/screen_size. I didn't find any differences or issue.
Screenshot 2024-12-13 at 2 58 39 PM

May be I missed something. Can u explain the issue(as I am unable to view the ticket u have mentioned in the description) and steps to test it out! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants