feat!: remove Transifex calls for FC-0012 - OEP-58 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
shadinaif
force-pushed
the
shadinaif/FC-0012-OEP-58.cleanup
branch
from
243c2e9
to
716688d
Compare
shadinaif
force-pushed
the
shadinaif/FC-0012-OEP-58.cleanup
branch
3 times, most recently
from
f4eaeb8
to
001c541
Compare
4 tasks
|
please review @OmarIthawi |
OmarIthawi
approved these changes
Feb 19, 2024
|
@shadinaif please set as |
OmarIthawi
force-pushed
the
shadinaif/FC-0012-OEP-58.cleanup
branch
from
c1f8888
to
059f445
Compare
OmarIthawi
force-pushed
the
shadinaif/FC-0012-OEP-58.cleanup
branch
from
059f445
to
ff48120
Compare
|
@shadinaif I've rebased and fixed conflicts with |
brian-smith-tcril
approved these changes
Mar 18, 2024
|
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change!
This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.
Changes
.poor.mofiles will be committed into the repos.tx pullandtx pushcommands from the XBlock to let Open edX manage it.Makefiletargets and configuration files.Use the OEP-58 JavaScript translations from the Open edX platformNAtransifex-clientfrom requirementsMerge timeline
This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.
The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.
## Keep this pull request as a draft to prevent an accidental merge. ##
Pre-merge checklist
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.