Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove locale files in favor of atlas - FC-0012 - OEP-58 #160

Conversation

shadinaif
Copy link

@shadinaif shadinaif commented Feb 19, 2024

Breaking change!

This PR is related to #157. But it is meant to be merged in a later phase.

Here we 100% comply with FC-0012 by not having any translation files living inside Open-edX repositories

Changes

  • Remove source and language translations from the repositories, hence no .po or .mo files will be committed into the repos.
  • Remove failing tests that require the presence of translation files

Merge timeline

## Keep this pull request as a draft to prevent an accidental merge. ##

Pre-merge checklist

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 19, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 19, 2024

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.remove-locale-files branch 2 times, most recently from b2fee5a to 2d5dd4d Compare February 19, 2024 10:12
@shadinaif
Copy link
Author

please review @OmarIthawi

@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.remove-locale-files branch from 2d5dd4d to 08c2608 Compare February 19, 2024 10:17
@itsjeyd itsjeyd added the blocked by other work PR cannot be finished until other work is complete label Feb 23, 2024
@OmarIthawi
Copy link
Member

@shadinaif please set as ready for merge by removing draft status.

@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review March 12, 2024 13:26
@OmarIthawi OmarIthawi removed the blocked by other work PR cannot be finished until other work is complete label Mar 17, 2024
@OmarIthawi
Copy link
Member

merging into #157

@OmarIthawi OmarIthawi closed this Mar 18, 2024
@openedx-webhooks
Copy link

@shadinaif Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants