Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to superset v4.1.0 #939

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: upgrade to superset v4.1.0 #939

wants to merge 9 commits into from

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Sep 11, 2024 •
edited
Loading

Description

This PR upgrades superset to v4.1.0

Now, we manually install MySQL client, see apache/superset#29727 for more information.

This PR also enables tagging and sets default tags to original and translated assets:
image

image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 11, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 11, 2024 •
edited
Loading

Thanks for the pull request, @Ian2012!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @bmtcril. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

saraburns1
saraburns1 reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@saraburns1 saraburns1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update the geckodriver & firefox versions. They changed from 4.0.2

ARG GECKODRIVER_VERSION=v0.34.0
ARG FIREFOX_VERSION=125.0.3

@Ian2012
Copy link
Contributor Author

Ian2012 commented Sep 12, 2024

I think it now comes pre-bundled in the image but I need to verify it

@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Sep 20, 2024
@Ian2012 Ian2012 force-pushed the cag/superset-4.1.0 branch 2 times, most recently from 5cc2c9b to 30146a0 Compare September 23, 2024 20:54
@Ian2012 Ian2012 marked this pull request as ready for review September 24, 2024 18:49
bmtcril
bmtcril reviewed Sep 25, 2024
View reviewed changes
tutoraspects/patches/k8s-deployments
@@ -216,6 +216,8 @@ spec:
name: docker
- mountPath: /app/pythonpath
name: pythonpath
- mountPath: /app/pythonpath/openedx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, why were these moves necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They upgraded the python version and that causes issues with imports without a module

@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Sep 26, 2024
saraburns1
saraburns1 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@saraburns1 saraburns1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE the asset tagging

bmtcril
bmtcril reviewed Sep 26, 2024
View reviewed changes
tutoraspects/templates/aspects/build/aspects-superset/Dockerfile Outdated
@@ -3,37 +3,30 @@
# https://github.com/apache/superset/releases
# https://github.com/apache/superset/blob/master/Dockerfile
# https://superset.apache.org/docs/databases/installing-database-drivers
FROM apache/superset:4.0.2
FROM apache/superset:4.1.0rc2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tagging this so no one merges, but we shouldn't take this change until at least 4.1.0 is released. It looks like there will be at least one more RC cycle until that happens, so we may want to make this a draft PR for now.

@Ian2012 Ian2012 marked this pull request as draft September 26, 2024 17:52
@Ian2012 Ian2012 force-pushed the cag/superset-4.1.0 branch 3 times, most recently from ea90a73 to 21ed833 Compare October 4, 2024 19:23
@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Oct 11, 2024
@itsjeyd
Copy link

itsjeyd commented Nov 7, 2024

Hey @Ian2012, just checking in to see if you're still planning to continue working on this PR?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Nov 7, 2024
@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 7, 2024

Yes, waiting on the official release before proceeding,

@itsjeyd
Copy link

itsjeyd commented Nov 14, 2024

@Ian2012 OK I see, thanks for the update!

@itsjeyd itsjeyd removed the inactive PR author has been unresponsive for several months label Nov 14, 2024
@itsjeyd itsjeyd added the blocked by other work PR cannot be finished until other work is complete label Nov 14, 2024
@Ian2012 Ian2012 marked this pull request as ready for review November 14, 2024 15:08
@bmtcril
Copy link
Contributor

bmtcril commented Nov 14, 2024

There's an issue on Superset right now about the images not being available yet: apache/superset#30919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmtcril bmtcril bmtcril left review comments

@saraburns1 saraburns1 saraburns1 approved these changes

Assignees
No one assigned
Labels
blocked by other work PR cannot be finished until other work is complete core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Contributions
Status: In Eng Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ian2012 @openedx-webhooks @itsjeyd @bmtcril @saraburns1