Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new strings for translation #842

Merged

Conversation

saraburns1
Copy link
Contributor

Closes #840

Add 2 new strings for translation
Reconfigure method for easier reading
Fix 'could not translate' errors

New strings:
image

Logs before:
image

Logs After:
image

@saraburns1 saraburns1 requested review from Ian2012 and bmtcril May 30, 2024 19:35
@saraburns1 saraburns1 force-pushed the saraburns1_translate_dashboard_string branch from dbff725 to 4e1ece9 Compare May 30, 2024 19:41
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it locally and it looks good! The only unexpected change in the output is:

'': ''

Which I think is fine. Should be the easiest translation for the team to review. :)

@bmtcril bmtcril merged commit 8c0c4bb into openedx:main May 31, 2024
9 checks passed
@saraburns1 saraburns1 deleted the saraburns1_translate_dashboard_string branch May 31, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract additional dashboard strings for translation
3 participants