style: fix a few pylint alerts #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feanil
approved these changes
Jul 26, 2023
feanil
reviewed
Jul 26, 2023
Makefile
Outdated
| @@ -38,6 +38,5 @@ upgrade: $(COMMON_CONSTRAINTS_TXT) ## update the requirements/*.txt files with | |||
| pip-compile --upgrade -o requirements/development.txt requirements/development.in | |||
| for fextra in edx_repo_tools/*/extra.in; do pip-compile --upgrade -o $${fextra%.in}.txt $$fextra; done | |||
|
|
|||
| lint: ## run pep8 and pylint | |||
| pep8 || true | |||
| lint: ## run pylint | |||
| pylint *.py edx_repo_tools tests || true | |||
There was a problem hiding this comment.
What's with the "Or True" here, should that be removed?
There was a problem hiding this comment.
Good point, it was being used to let targets succeed and ignore the exit status. It was important on pep8 so that pylint would also run, but we don't need it here.
I think pylint hasn't been run here in a very long time. This removes pep8 which isn't called correctly, and fixes a few actual issues in modules I've touched recently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think pylint hasn't been run here in a very long time. This removes pep8 which isn't called correctly, and fixes a few actual issues in modules I've touched recently.