Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Support Window spreadsheet #414

Merged
merged 10 commits into from
Jul 18, 2023
Merged

fix: Update Support Window spreadsheet #414

merged 10 commits into from
Jul 18, 2023

Commits on Jul 18, 2023

  1. fix: Update Elasticsearch support dates 

    Add support date for Elasticsearch version 7.17.

Did not include support dates for previous versions between 7.14 and
7.16 inclusive.
    @MimmyJau
    MimmyJau authored and Ned Batchelder committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    cde0cb3 View commit details
    Browse the repository at this point in the history

  2. chore: Add auto pull version from tutor's config 

    Add functions for automatically pulling version number from tutor's
default config file and choosing which bars to bold and outline.

This pulls the name and / or number for the current version of openedx,
MongoDB, Elasticsearch, MySQL, and Redis. It does not pull the current
version of Python, Django, Ubuntu, Node, or Ruby.

To be clear, this commit doesn't add new bars to the calendar, it only
automates how we choose which bars to bold and outline. For example, if
we were to switch to Elasticsearch 8.x.x, we'll still need to manually
add the release and EOL dates.
    @MimmyJau
    MimmyJau authored and Ned Batchelder committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    7e4b116 View commit details
    Browse the repository at this point in the history

  3. fix: Regex to match version name if suffix is word 

    See here for original comment:
openedx#414 (comment)

Version name might be something like "palm.master", in which case we
don't just want to capture a version number.
    @MimmyJau
    MimmyJau authored and Ned Batchelder committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    28065b7 View commit details
    Browse the repository at this point in the history

  4. refactor: Import yaml library for consistency 

    Was previously importing a specific function but this was not consistent
with style.

See here for original comment:
openedx#414 (comment)
    @MimmyJau
    MimmyJau authored and Ned Batchelder committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    dbecbc7 View commit details
    Browse the repository at this point in the history

  5. fix: Raise error if status code isn't 200 

    Before, if http request to tutor's defaults.yml returned status code !=
200, function would return None and continue. No error would be
raised.

This fix now raises a RuntimError.

See here for original comment:
openedx#414 (comment)
    @MimmyJau
    MimmyJau authored and Ned Batchelder committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    a3e7a3b View commit details
    Browse the repository at this point in the history

  6. refactor: Remove f-string for single expressions 

    f-string is unnecessary if the string is a single Python expression.
Replaced f-string with just the expression where possible.

See here for original comment:
openedx#414 (comment)
    @MimmyJau
    MimmyJau authored and Ned Batchelder committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    99fc5fa View commit details
    Browse the repository at this point in the history

  7. fix: Simplify regex for matching version name

    @MimmyJau
    MimmyJau authored and Ned Batchelder committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    0bb8db6 View commit details
    Browse the repository at this point in the history

  8. fix: Use requests' built-in method to raise exc

    @MimmyJau
    MimmyJau authored and Ned Batchelder committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    9b46aff View commit details
    Browse the repository at this point in the history

  9. refactor: Separate third-party imports from built-in 

    Co-authored-by: Ned Batchelder <[email protected]>
    @MimmyJau @nedbat
    MimmyJau and nedbat authored Jul 18, 2023
    Configuration menu
    Copy the full SHA
    cfae02f View commit details
    Browse the repository at this point in the history

  10. fix: Raise error if version name/number not found 

    Before, if version name or number wasn't found, will continue to run
program and generate a bar calendar that doesn't have bolded bars. Want
to instead raise an error.

See here for original comment:
openedx#414 (comment)
    @MimmyJau
    MimmyJau committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    f98140b View commit details
    Browse the repository at this point in the history