Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPR]: Remove JWT_AUTH_REFRESH_COOKIE #190

Closed
robrap opened this issue Apr 13, 2023 · 7 comments
Closed

[DEPR]: Remove JWT_AUTH_REFRESH_COOKIE #190

robrap opened this issue Apr 13, 2023 · 7 comments
Assignees
@Yagnesh1998
Labels
depr Proposal for deprecation & removal per OEP-21 good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community

Comments

@robrap
Copy link

robrap commented Apr 13, 2023 •
edited
Loading

Proposal Date

2023-04-12

Target Ticket Acceptance Date

2023-06-15

Earliest Open edX Named Release Without This Functionality

Quince - 2023-10

Rationale

The setting JWT_AUTH_REFRESH_COOKIE is meaningless and unused, and should be cleaned up to avoid confusion.

In the very early days of introducing MFEs, we thought we were going to need this cookie in addition to the JWT cookie. However, it turned out we didn't need it, but the setting stuck around the contagion of it (being in cookiecutter and other template libraries) has resulted in it uselessly being copied to many repos.

Removal

The setting JWT_AUTH_REFRESH_COOKIE can simply be removed with no ramifications.

Replacement

No replacement needed.

Deprecation

No response

Migration

No response

Additional Info
@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label Apr 13, 2023
@robrap robrap mentioned this issue Apr 17, 2023
Open
@robrap robrap moved this from Proposed to Communicated in DEPR: Deprecation & Removal Jun 15, 2023
@robrap robrap moved this from Communicated to Accepted in DEPR: Deprecation & Removal Jun 15, 2023
@dianakhuang dianakhuang added good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community labels Jun 29, 2023
@Yagnesh1998 Yagnesh1998 mentioned this issue Jul 5, 2023
Closed
robrap added a commit to openedx/edx-cookiecutters that referenced this issue Jul 5, 2023
@robrap
fix: remove unused JWT_AUTH_REFRESH_COOKIE
9fb3e1e 
Remove the setting JWT_AUTH_REFRESH_COOKIE
which serves no purpose.

See DEPR: openedx/public-engineering#190
@robrap robrap mentioned this issue Jul 5, 2023
Merged
6 tasks
Yagnesh1998 pushed a commit to ManpraXSoftware/edx-platform that referenced this issue Jul 6, 2023
feat: Remove JWT_AUTH_REFRESH_COOKIE Setting openedx/public-engineeri…
f0737de 
…ng#190
Yagnesh1998 pushed a commit to ManpraXSoftware/edx-platform that referenced this issue Jul 6, 2023
feat: Remove JWT_AUTH_REFRESH_COOKIE Setting openedx/public-engineeri…
aeb35e8 
…ng#190
This was referenced Jul 6, 2023
Closed
Closed
Merged
@Yagnesh1998
Copy link

@dianakhuang openedx/edx-platform#32664 This pull request all tests passed successfully

robrap added a commit to openedx/edx-cookiecutters that referenced this issue Jul 7, 2023
@robrap
fix: remove unused JWT_AUTH_REFRESH_COOKIE
4cc7487 
Remove the setting JWT_AUTH_REFRESH_COOKIE
which serves no purpose.

See DEPR: openedx/public-engineering#190
robrap added a commit to openedx/edx-cookiecutters that referenced this issue Jul 7, 2023
@robrap
fix: remove unused JWT_AUTH_REFRESH_COOKIE (#362)
6fe96b7 
Remove the setting JWT_AUTH_REFRESH_COOKIE
which serves no purpose.

See DEPR: openedx/public-engineering#190
@robrap robrap mentioned this issue Jul 10, 2023
Closed
@robrap
Copy link
Author

robrap commented Jul 10, 2023 •
edited
Loading

[inform] I moved the edx org work to a separate ticket that would not block this DEPR: edx/edx-arch-experiments#353.

@dianakhuang dianakhuang moved this from Accepted to Removing in DEPR: Deprecation & Removal Jul 27, 2023
@robrap
Copy link
Author

robrap commented Sep 22, 2023

@Yagnesh1998: If you could start by removing this from openedx/configuration. See https://github.com/search?q=repo%3Aopenedx%2Fconfiguration+JWT_AUTH_REFRESH_COOKIE&type=code. Once this is done, you can fix other repos. Thank you.

@Yagnesh1998
Copy link

assign me

@Yagnesh1998 Yagnesh1998 mentioned this issue Oct 10, 2023
Merged
robrap pushed a commit to openedx-unsupported/configuration that referenced this issue Oct 11, 2023
@Yagnesh1998
feat: Remove JWT_AUTH_REFRESH_COOKIE (#7042)
8da3ed0 
The setting JWT_AUTH_REFRESH_COOKIE is meaningless and unused
and is being cleaned up to avoid confusion.

See DEPR: openedx/public-engineering#190
@lokidil
Copy link

lokidil commented Oct 15, 2023

anyone is working on this ? is this closed ?

@Yagnesh1998
Copy link

Yagnesh1998 commented Oct 15, 2023 •
edited
Loading

@lokidil I'm working on it. Thanks.

@Yagnesh1998 Yagnesh1998 mentioned this issue Oct 16, 2023
Merged
@Yagnesh1998 Yagnesh1998 mentioned this issue Oct 17, 2023
Merged
robrap pushed a commit to openedx/enterprise-catalog that referenced this issue Oct 17, 2023
@Yagnesh1998
feat: remove JWT_AUTH_REFRESH_COOKIE depr190 (#698)
546187f 
See openedx/public-engineering#190
robrap pushed a commit to openedx-unsupported/devstack that referenced this issue Oct 17, 2023
@Yagnesh1998
feat: remove JWT_AUTH_REFRESH_COOKIE depr190 (#1211)
0ffb265 
See DEPR: openedx/public-engineering#190
robrap pushed a commit to openedx/enterprise-subsidy that referenced this issue Oct 17, 2023
@Yagnesh1998
feat: remove JWT_AUTH_REFRESH_COOKIE depr190 (#157)
bbaf930 
See DEPR openedx/public-engineering#190
robrap pushed a commit to openedx/license-manager that referenced this issue Oct 17, 2023
@Yagnesh1998
feat: remove JWT_AUTH_REFRESH_COOKIE depr190 (#534)
36c620e 
See DEPR openedx/public-engineering#190
@robrap
Copy link
Author

robrap commented Oct 17, 2023

Although there are still edx repos to complete, the openedx repos are complete and I am marking this as closed. Thank you @Yagnesh1998.

@robrap robrap closed this as completed Oct 17, 2023
@github-project-automation github-project-automation bot moved this from Removing to Removed in DEPR: Deprecation & Removal Oct 17, 2023
This was referenced Oct 23, 2023
Closed
Closed
Closed
Closed
robrap added a commit to edx/edx-exams that referenced this issue Nov 6, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE
45cd9fb 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
robrap added a commit to edx/portal-designer that referenced this issue Nov 6, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE
43a908e 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
@robrap robrap mentioned this issue Nov 6, 2023
Merged
robrap added a commit to edx/sanctions that referenced this issue Nov 6, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE
181f6a1 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
@robrap robrap mentioned this issue Nov 6, 2023
Merged
robrap added a commit to edx/program-intent-engagement that referenced this issue Nov 6, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE
f9558a1 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
@robrap robrap mentioned this issue Nov 6, 2023
Merged
robrap added a commit to edx/commerce-coordinator that referenced this issue Nov 6, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE
ec1f075 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
@robrap robrap mentioned this issue Nov 6, 2023
Merged
robrap added a commit to edx/program-intent-engagement that referenced this issue Nov 6, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE (#94)
4bb866c 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
robrap added a commit to edx/commerce-coordinator that referenced this issue Nov 6, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE (#127)
83ebddc 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
robrap added a commit to edx/portal-designer that referenced this issue Nov 6, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE (#280)
f674060 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
robrap added a commit to edx/sanctions that referenced this issue Nov 6, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE (#13)
55a72ca 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
robrap added a commit to edx/edx-exams that referenced this issue Nov 7, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE
f6dedb6 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
@robrap robrap mentioned this issue Nov 7, 2023
Merged
4 tasks
robrap added a commit to edx/edx-exams that referenced this issue Nov 7, 2023
@robrap
fix: remove JWT_AUTH_REFRESH_COOKIE (#211)
912d1ae 
Remove unused JWT_AUTH_REFRESH_COOKIE setting. This
setting was never actually used, so there is no timing issues.

See DEPR for details:
openedx/public-engineering#190
nsprenkle pushed a commit to openedx-unsupported/devstack that referenced this issue Nov 21, 2023
@Yagnesh1998 @nsprenkle
feat: remove JWT_AUTH_REFRESH_COOKIE depr190 (#1211)
cc12195 
See DEPR: openedx/public-engineering#190
irfanuddinahmad pushed a commit to openedx/enterprise-catalog that referenced this issue Jul 24, 2024
@Yagnesh1998
feat: remove JWT_AUTH_REFRESH_COOKIE depr190 (#698)
66941f0 
See openedx/public-engineering#190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yagnesh1998 Yagnesh1998

Labels
depr Proposal for deprecation & removal per OEP-21 good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community
Projects
DEPR: Deprecation & Removal
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dianakhuang @lokidil @robrap @Yagnesh1998