Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove JWT_AUTH_REFRESH_COOKIE #277

Closed
wants to merge 1 commit into from

Conversation

Yagnesh1998
Copy link

Description:
The setting JWT_AUTH_REFRESH_COOKIE is meaningless and unused and should be cleaned up to avoid confusion.
In the very early days of introducing MFEs, we thought we were going to need this cookie in addition to the JWT cookie. However, it turned out we didn't need it, but the setting stuck around the contagion of it (being in cookiecutter and other template libraries) has resulted in it uselessly being copied to many repos.

Supporting information:
as per the original ticket openedx/public-engineering#190, this setting is removed.

Rationale
The setting JWT_AUTH_REFRESH_COOKIE is meaningless and unused, and should be cleaned up to avoid confusion.

In the very early days of introducing MFEs, we thought we were going to need this cookie in addition to the JWT cookie. However, it turned out we didn't need it, but the setting stuck around the contagion of it (being in cookiecutter and other template libraries) has resulted in it uselessly being copied to many repos.

Removal
The setting JWT_AUTH_REFRESH_COOKIE can simply be removed with no ramifications.

@openedx-webhooks
Copy link

Thanks for your pull request, but this repo does not accept outside contributions unless they are under contract. If you think this is an error, please contact @nedbat.

@nedbat
Copy link
Contributor

nedbat commented Oct 24, 2023

I'll close this since this repo does not accept outside contributions.

@nedbat nedbat closed this Oct 24, 2023
@Yagnesh1998 Yagnesh1998 deleted the edx-depr190 branch October 24, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants