-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added expanded tokens #3222
feat: added expanded tokens #3222
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Peter_Kulko/style-dictionary-v4 #3222 +/- ##
================================================================
Coverage 93.76% 93.76%
================================================================
Files 229 229
Lines 3784 3784
Branches 902 906 +4
================================================================
Hits 3548 3548
- Misses 229 232 +3
+ Partials 7 4 -3 ☔ View full report in Codecov by Sentry. |
86566bb
to
55c47d5
Compare
55c47d5
to
0c73ba7
Compare
daffd74
to
a0baaa6
Compare
0c73ba7
to
2311ec1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming together beautifully! Left a couple comments where the diff doesn't match up with what was being discussed in prior comment threads, but overall it's looking great!
39448d8
to
9726e14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through all of the places mentioned in #3222 (comment) and added checkmarks. Most of them look perfect! I left comments on the ones that I noticed issues with:
Find where we're using the consolidated token
- Done?
"header": { "source": "$dropdown-header-padding", "$value": "{spacing.dropdown.padding.y.base} {spacing.dropdown.padding.x.item}" }
Make composite token
- Done?
"$value": "all .2s ease-in-out",
Make composite token
- Done?
"$value": "-apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, 'Noto Sans', sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji'",
55987e0
to
2786dd4
Compare
2786dd4
to
0905115
Compare
@brian-smith-tcril @adamstankiewicz there seems to be a small issue with the fonts after the latest changes to the documentation site. It may have happened after this |
@PKulkoRaccoonGang I believe this style discrepancy might be resolved by addressing this comment. By ensuring the token value is an array of multiple elements (one per font) vs. a single array element containing all fonts, it seems like the font size and typography style will be fixed, as seen below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking through the wild ride of a PR review this was! Let's land this!
Great job, @PKulkoRaccoonGang! Excited to see this land. Thanks for working through the iterations. |
refactor: corrected expanded tokens refactor: code refactoring refactor: created an abstracted CSS variables refactor: added missing expanded tokens refactor: added missing expanded tokens refactor: small refactoring after review refactor: corrected imports for CSS files feat: expanded --pgn-transition-carousel-base token, some refactoring fix: corrected --pgn-transition-base-timing-function value refactor: some refactoring and updates refactor: corrected progress-bar and typography tokens
4e9134e
to
5b0e94f
Compare
70673e4
into
Peter_Kulko/style-dictionary-v4
Description
Merge Checklist
example
app?Post-merge Checklist