Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Suggest Fix: allows focus to return to input after hitting esc #2556

Conversation

cintnguyen
Copy link
Contributor

@cintnguyen cintnguyen commented Aug 16, 2023

Description

Resolves #2516

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a122e04
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6500bfb16fa63200089ae9dd
😎 Deploy Preview https://deploy-preview-2556--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brian-smith-tcril brian-smith-tcril added the blocked by other work PR cannot be finished until other work is complete label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07% 🎉

Comparison is base (23b83c5) 91.81% compared to head (a122e04) 91.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2556      +/-   ##
==========================================
+ Coverage   91.81%   91.89%   +0.07%     
==========================================
  Files         235      235              
  Lines        4217     4220       +3     
  Branches     1020     1021       +1     
==========================================
+ Hits         3872     3878       +6     
+ Misses        341      338       -3     
  Partials        4        4              
Files Changed Coverage Δ
src/Form/FormAutosuggest.jsx 96.87% <100.00%> (+3.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cintnguyen cintnguyen force-pushed the cindy/formAutosuggest-esc-behavior branch from 812c31b to 78945df Compare August 23, 2023 19:15
@cintnguyen cintnguyen force-pushed the cindy/formAutosuggest-esc-behavior branch from 78945df to 0d9e6a5 Compare September 12, 2023 19:35
@cintnguyen cintnguyen force-pushed the cindy/formAutosuggest-esc-behavior branch from 0d9e6a5 to a122e04 Compare September 12, 2023 19:44
@cintnguyen cintnguyen marked this pull request as ready for review September 12, 2023 19:46
@brian-smith-tcril brian-smith-tcril removed the blocked by other work PR cannot be finished until other work is complete label Sep 12, 2023
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brian-smith-tcril brian-smith-tcril merged commit 34f055a into openedx:master Oct 12, 2023
9 checks passed
@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autosuggest: set focus back to text box when pressing esc in dropdown
3 participants