-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: skeleton.css for both dev and prod #2531
[BD-46] fix: skeleton.css for both dev and prod #2531
Conversation
Thanks for the pull request, @monteri! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2531 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 236 236
Lines 4195 4195
Branches 1012 1012
=======================================
Hits 3845 3845
Misses 346 346
Partials 4 4 ☔ View full report in Codecov by Sentry. |
@adamstankiewicz @monteri checked for performance in the MFE frontend-app-course-authoring |
Great, thanks! I've also verified this change on my machine locally with the Paragon repo (docs site + example MFE) and the frontend-template-application MFE ( |
@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This reverts commit 7e96a0a.
Description
The issue was that in the prod environment Skeleton didn't show up. The fix is to use
@use
instead of@import
.#2420
Deploy Preview
https://deploy-preview-2531--paragon-openedx.netlify.app/components/skeleton/
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist