Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-46] fix: specific icons fix #2442

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[BD-46] fix: specific icons fix #2442

merged 1 commit into from
Jul 14, 2023

Conversation

monteri
Copy link
Contributor

@monteri monteri commented Jul 14, 2023

Description

Three icons with different colors are turned into black-and-white icons.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Jul 14, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @monteri!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Jul 14, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9a48176
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64b13aa80634140008b3aa48
😎 Deploy Preview https://deploy-preview-2442--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@monteri monteri self-assigned this Jul 14, 2023
@adamstankiewicz adamstankiewicz merged commit 1ae20f3 into openedx:master Jul 14, 2023
@openedx-webhooks
Copy link

@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 20.45.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

pedromartello pushed a commit to hammerlabs-net/paragon that referenced this pull request Aug 10, 2023
@monteri @pedromartello
fix: specific icons fix to ensure icons display correctly when used (o…
740fa9f 
…penedx#2442)

Co-authored-by: monteri <lansevermore>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKulkoRaccoonGang PKulkoRaccoonGang PKulkoRaccoonGang approved these changes

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

Assignees

@monteri monteri

Labels
blended PR is managed through 2U's blended developmnt program raccoon-gang released
Projects
No open projects
2U Blended Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@monteri @openedx-webhooks @edx-semantic-release @adamstankiewicz @PKulkoRaccoonGang