Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: move Enzyme to React testing library #2440

Conversation

PKulkoRaccoonGang
Copy link
Contributor

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 13, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 13, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f41ecf9
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/64db45521072b40007f8384d
😎 Deploy Preview https://deploy-preview-2440--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PKulkoRaccoonGang PKulkoRaccoonGang changed the title Zadorozhnii/refactor enzyme tests [BD-46] feat: move Enzyme to React testing library Jul 13, 2023
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Jul 13, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft July 13, 2023 19:12
@monteri monteri force-pushed the zadorozhnii/refactor-enzyme-tests branch from 56903ba to f41ecf9 Compare August 15, 2023 09:28
@brian-smith-tcril
Copy link
Contributor

@cintnguyen and I will take on the effort of moving Form.AutoSuggest tests over to RTL, so those can be excluded from this PR.

@openedx-webhooks
Copy link

@PKulkoRaccoonGang Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants