-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renamed duplicate component imports #2405
Conversation
Thanks for the pull request, @anjali29singh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/index.scss
Outdated
@import "./AvatarButton/index"; | ||
@import "./Badge/index"; | ||
@import "./Breadcrumb/index"; | ||
@import "./Button/index"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@import "./Button/index"; | |
@import "./Button"; |
Thank you for your effort and contribution to the project. We've reviewed the work so far, and we have a suggestion for improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@monteri thank you for suggestion . I will make the above changes.
@anjali29singh Noticed the We'll need the |
@import "./DataTable/DataTable"; | ||
@import "./TransitionReplace/TransitionReplace"; | ||
@import "./ValidationMessage/ValidationMessage"; | ||
@import "./Tabs/deprecated/Tabs"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this line is causing the build to break (e.g., prevents the Netlify deploy preview from generating).
5:28:52 AM: formatted: Error: Can't find stylesheet to import.\n +
5:28:52 AM: ' ╷\n' +
5:28:52 AM: '44 │ @import ./Tabs/deprecated;\n' +
@anjali29singh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This pull request will resolve issue #2387 .
I have renamed the files present in src directory to avoid confusion while importing styles .
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist