Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed duplicate component imports #2405

Closed
wants to merge 3 commits into from

Conversation

anjali29singh
Copy link
Contributor

@anjali29singh anjali29singh commented Jun 27, 2023

Description

This pull request will resolve issue #2387 .
I have renamed the files present in src directory to avoid confusion while importing styles .

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 27, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @anjali29singh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit aecfd8f
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/649b15b5c3572d00085680c4
😎 Deploy Preview https://deploy-preview-2405--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/index.scss Outdated
@import "./AvatarButton/index";
@import "./Badge/index";
@import "./Breadcrumb/index";
@import "./Button/index";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@import "./Button/index";
@import "./Button";

Thank you for your effort and contribution to the project. We've reviewed the work so far, and we have a suggestion for improvement.

Copy link
Contributor Author

@anjali29singh anjali29singh Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monteri thank you for suggestion . I will make the above changes.

@adamstankiewicz
Copy link
Member

@anjali29singh Noticed the openedx/cla status check is failing. Check the "How to Start Contributing Code" documentation that explains the need and how to sign Contributor Agreement: https://openedx.atlassian.net/wiki/spaces/COMM/pages/941457737/How+to+Start+Contributing+Code#Start-Here!

We'll need the openedx/cla status check to be passing before we can accept the contribution.

@import "./DataTable/DataTable";
@import "./TransitionReplace/TransitionReplace";
@import "./ValidationMessage/ValidationMessage";
@import "./Tabs/deprecated/Tabs";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this line is causing the build to break (e.g., prevents the Netlify deploy preview from generating).

5:28:52 AM:   formatted: Error: Can't find stylesheet to import.\n +
5:28:52 AM:     '\n' +
5:28:52 AM:     '44 │ @import ./Tabs/deprecated;\n' +

@openedx-webhooks
Copy link

@anjali29singh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants